storage/browser/blob/blob_url_request_job.cc - Issue 1563633002: Make URLRequestJob::SetStatus private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_url_request_job.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/blob/blob_url_request_job.cc

diff --git a/storage/browser/blob/blob_url_request_job.cc b/storage/browser/blob/blob_url_request_job.cc

index 783c3866ba55fef0f4015fdec7f8d2940b106350..58863d00355b460ca2a9da6927b74d870f6a948c 100644

--- a/storage/browser/blob/blob_url_request_job.cc

+++ b/storage/browser/blob/blob_url_request_job.cc

@@ -177,7 +177,6 @@ void BlobURLRequestJob::DidStart() {

NotifyFailure(blob_reader_->net_error());

return;

case BlobReader::Status::IO_PENDING:

- SetStatus(net::URLRequestStatus(net::URLRequestStatus::IO_PENDING, 0));

return;

case BlobReader::Status::DONE:

DidCalculateSize(net::OK);

@@ -188,8 +187,6 @@ void BlobURLRequestJob::DidStart() {

void BlobURLRequestJob::DidCalculateSize(int result) {

TRACE_EVENT_ASYNC_END1("Blob", "BlobRequest::CountSize", this, "uuid",

blob_handle_->uuid());

- // Clear the IO_PENDING status

- SetStatus(net::URLRequestStatus());

if (result != net::OK) {

NotifyFailure(result);