Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index adce41b311fee4f6379c0bf815ce7abc915486e1..dbcc8caab14c6263b055302ffcadfd3b30cce141 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -22,12 +22,8 @@ namespace {
class MockURLRequestJob : public URLRequestJob {
public:
- MockURLRequestJob(URLRequest* request,
- NetworkDelegate* network_delegate,
- const URLRequestStatus& status)
- : URLRequestJob(request, network_delegate),
- status_(status),
- weak_factory_(this) {}
+ MockURLRequestJob(URLRequest* request, NetworkDelegate* network_delegate)
+ : URLRequestJob(request, network_delegate), weak_factory_(this) {}
void Start() override {
// Start reading asynchronously so that all error reporting and data
@@ -42,11 +38,9 @@ class MockURLRequestJob : public URLRequestJob {
private:
void StartAsync() {
- SetStatus(status_);
NotifyHeadersComplete();
}
- URLRequestStatus status_;
base::WeakPtrFactory<MockURLRequestJob> weak_factory_;
};
@@ -55,10 +49,7 @@ class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
URLRequestJob* MaybeCreateJob(
URLRequest* request,
NetworkDelegate* network_delegate) const override {
- return new MockURLRequestJob(
- request,
- network_delegate,
- URLRequestStatus(URLRequestStatus::SUCCESS, OK));
+ return new MockURLRequestJob(request, network_delegate);
}
};

Powered by Google App Engine
This is Rietveld 408576698