Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: net/url_request/url_request_job.h

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index 2fbf70e39bcf415e06a9f9230095b046f11ff4bb..9555b67f0f2b7ac4ced49e411d34f59ac34cd5fa 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -337,9 +337,6 @@ class NET_EXPORT URLRequestJob : public base::PowerObserver {
// The status of the job.
const URLRequestStatus GetStatus();
- // Set the status of the job.
- void SetStatus(const URLRequestStatus& status);
-
// Set the proxy server that was used, if any.
void SetProxyServer(const HostPortPair& proxy_server);
@@ -366,6 +363,10 @@ class NET_EXPORT URLRequestJob : public base::PowerObserver {
URLRequest* request_;
private:
+ // Set the status of the associated URLRequest.
+ // TODO(mmenke): Make the URLRequest manage its own status.
+ void SetStatus(const URLRequestStatus& status);
+
// When data filtering is enabled, this function is used to read data
// for the filter. Returns a net error code to indicate if raw data was
// successfully read, an error happened, or the IO is pending.

Powered by Google App Engine
This is Rietveld 408576698