Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: net/url_request/url_request_ftp_job.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_ftp_job.cc
diff --git a/net/url_request/url_request_ftp_job.cc b/net/url_request/url_request_ftp_job.cc
index 596363f8535b20b4794d51b86ba1a413acc2be1a..fd59e45e9f40727592811951ed80623368a2f608 100644
--- a/net/url_request/url_request_ftp_job.cc
+++ b/net/url_request/url_request_ftp_job.cc
@@ -160,9 +160,6 @@ void URLRequestFtpJob::StartFtpTransaction() {
ftp_request_info_.url = request_->url();
ftp_transaction_ = ftp_transaction_factory_->CreateTransaction();
- // No matter what, we want to report our status as IO pending since we will
- // be notifying our consumer asynchronously via OnStartCompleted.
- SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
int rv;
if (ftp_transaction_) {
rv = ftp_transaction_->Start(
@@ -211,9 +208,6 @@ void URLRequestFtpJob::StartHttpTransaction() {
}
void URLRequestFtpJob::OnStartCompleted(int result) {
- // Clear the IO_PENDING status
- SetStatus(URLRequestStatus());
-
// Note that ftp_transaction_ may be NULL due to a creation failure.
if (ftp_transaction_) {
// FTP obviously doesn't have HTTP Content-Length header. We have to pass
@@ -257,10 +251,6 @@ void URLRequestFtpJob::OnReadCompleted(int result) {
void URLRequestFtpJob::RestartTransactionWithAuth() {
DCHECK(auth_data_.get() && auth_data_->state == AUTH_STATE_HAVE_AUTH);
- // No matter what, we want to report our status as IO pending since we will
- // be notifying our consumer asynchronously via OnStartCompleted.
- SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
-
int rv;
if (proxy_info_.is_direct()) {
rv = ftp_transaction_->RestartWithAuth(

Powered by Google App Engine
This is Rietveld 408576698