Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: content/public/test/test_download_request_handler.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_download_request_handler.cc
diff --git a/content/public/test/test_download_request_handler.cc b/content/public/test/test_download_request_handler.cc
index 89e2cdc1180c0c618b9eaf1a500f9f85f1818c4d..ea6dc356726ac80cf3b5ad505ca3181eeaac865d 100644
--- a/content/public/test/test_download_request_handler.cc
+++ b/content/public/test/test_download_request_handler.cc
@@ -285,7 +285,6 @@ int TestDownloadRequestHandler::PartialResponseJob::ReadRawData(
if (offset_of_next_read_ == injected_error.offset) {
int error = injected_error.error;
- SetStatus(net::URLRequestStatus(net::URLRequestStatus::FAILED, error));
DVLOG(1) << "Returning error " << net::ErrorToString(error);
ReportCompletedRequest(injected_error.offset - requested_range_begin_);
parameters_->injected_errors.pop();
@@ -353,7 +352,6 @@ void TestDownloadRequestHandler::PartialResponseJob::OnStartResponseCallback(
void TestDownloadRequestHandler::PartialResponseJob::HandleOnStartDefault() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- SetStatus(net::URLRequestStatus());
const net::HttpRequestHeaders& extra_headers =
request()->extra_request_headers();
@@ -367,8 +365,9 @@ void TestDownloadRequestHandler::PartialResponseJob::HandleOnStartDefault() {
// ETag, then try to handle the range request.
if (parameters_->support_byte_ranges &&
extra_headers.GetHeader(net::HttpRequestHeaders::kIfRange, &value) &&
- value == parameters_->etag && HandleRangeAssumingValidatorMatch())
+ value == parameters_->etag && HandleRangeAssumingValidatorMatch()) {
return;
+ }
if (parameters_->support_byte_ranges &&
extra_headers.GetHeader("If-Match", &value)) {

Powered by Google App Engine
This is Rietveld 408576698