content/browser/service_worker/service_worker_read_from_cache_job.cc - Issue 1563633002: Make URLRequestJob::SetStatus private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/net/android_stream_reader_url_request_job.cc ('K') | « android_webview/browser/net/android_stream_reader_url_request_job.cc ('k') | content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc » ('j') | content/browser/streams/stream_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_read_from_cache_job.cc

diff --git a/content/browser/service_worker/service_worker_read_from_cache_job.cc b/content/browser/service_worker/service_worker_read_from_cache_job.cc

index bd9844b327ed7175425d7bcc38214951264e87b4..24f84342fed1673dfaeb3961aa98a24ab6ea9a92 100644

--- a/content/browser/service_worker/service_worker_read_from_cache_job.cc

+++ b/content/browser/service_worker/service_worker_read_from_cache_job.cc

@@ -139,7 +139,6 @@ void ServiceWorkerReadFromCacheJob::StartAsync() {

http_info_io_buffer_.get(),

base::Bind(&ServiceWorkerReadFromCacheJob::OnReadInfoComplete,

weak_factory_.GetWeakPtr()));

- SetStatus(net::URLRequestStatus(net::URLRequestStatus::IO_PENDING, 0));

}

const net::HttpResponseInfo* ServiceWorkerReadFromCacheJob::http_info() const {

@@ -161,7 +160,6 @@ void ServiceWorkerReadFromCacheJob::OnReadInfoComplete(int result) {

return;

}

DCHECK_GE(result, 0);

- SetStatus(net::URLRequestStatus()); // Clear the IO_PENDING status

http_info_.reset(http_info_io_buffer_->http_info.release());

if (is_range_request())

SetupRangeResponse(http_info_io_buffer_->response_data_size);