Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 1563633002: Make URLRequestJob::SetStatus private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix stuff Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.cc
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc
index f0b6a52f2c35427cb87f1ac424dcd13c611e6c74..c4c9b679bc377454a080d9391058d47a978a9865 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc
@@ -364,12 +364,10 @@ void ServiceWorkerWriteToCacheJob::OnWriteHeadersComplete(net::Error error) {
NotifyStartError(net::URLRequestStatus::FromError(error));
return;
}
- SetStatus(net::URLRequestStatus());
NotifyHeadersComplete();
}
void ServiceWorkerWriteToCacheJob::OnWriteDataComplete(net::Error error) {
- SetStatus(net::URLRequestStatus::FromError(error));
DCHECK_NE(net::ERR_IO_PENDING, error);
if (io_buffer_bytes_ == 0)
error = NotifyFinishedCaching(net::URLRequestStatus::FromError(error), "");
@@ -451,7 +449,6 @@ void ServiceWorkerWriteToCacheJob::NotifyStartErrorHelper(
net::URLRequestStatus reported_status = status;
std::string reported_status_message = status_message;
- SetStatus(reported_status);
NotifyStartError(reported_status);
}

Powered by Google App Engine
This is Rietveld 408576698