third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_query.html - Issue 1563623002: Support registering and dispatching passive event listeners.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_query.html

Issue 1563623002: Support registering and dispatching passive event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_dispatch.html ('K') | « third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_dispatch.html ('k') | third_party/WebKit/Source/core/events/Event.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <body/>	2 <body/>

3 <script src="../../../resources/testharness.js"></script>	3 <script src="../../../resources/testharness.js"></script>

4 <script src="../../../resources/testharnessreport.js"></script>	4 <script src="../../../resources/testharnessreport.js"></script>

5	5

6 <script>	6 <script>

7 test(function(t) {	7 test(function(t) {

8 var supportsCapture = false;	8 var supportsPassive = false;

9 var query_function = function(e) {};	9 var query_function = function(e) {};

10 var query_options = {	10 var query_options = {

11 get capture() {	11 get passive() {

12 supportsCapture = true;	12 supportsPassive = true;

13 return false;	13 return false;

14 },	14 },

15 get dummy() {	15 get dummy() {

16 assert_unreached("dummy value getter invoked");	16 assert_unreached("dummy value getter invoked");

17 return false;	17 return false;

18 }	18 }

19 };	19 };

20	20

21 document.addEventListener('test_event', query_function, query_options);	21 document.addEventListener('test_event', query_function, query_options);

22 assert_equals(supportsCapture, internals.runtimeFlags.eventListenerOptionsEn abled);	22 assert_equals(supportsPassive, internals.runtimeFlags.eventListenerOptionsEn abled);
	Rick Byers 2016/01/08 19:32:56 I guess this could be a good place to verify that I guess this could be a good place to verify that the runtime enabled feature is correctly supporting the feature detection. I.e. instead of just testing whatever the default state is, assert that it's enabled (I don't think we'd ever put the feature below "test" status), verify the feature detection passes, then disable it and verify the feature detection fails. WDYT? dtapuska 2016/01/11 18:56:28 Is this not doing it when it runs via the stable t Show quoted text On 2016/01/08 19:32:56, Rick Byers wrote: > I guess this could be a good place to verify that the runtime enabled feature is > correctly supporting the feature detection. I.e. instead of just testing > whatever the default state is, assert that it's enabled (I don't think we'd ever > put the feature below "test" status), verify the feature detection passes, then > disable it and verify the feature detection fails. WDYT? Is this not doing it when it runs via the stable test? Rick Byers 2016/01/11 22:37:05 Ah, I forgot this entire directly is enabled for v Show quoted text On 2016/01/11 18:56:28, dtapuska wrote: > On 2016/01/08 19:32:56, Rick Byers wrote: > > I guess this could be a good place to verify that the runtime enabled feature > is > > correctly supporting the feature detection. I.e. instead of just testing > > whatever the default state is, assert that it's enabled (I don't think we'd > ever > > put the feature below "test" status), verify the feature detection passes, > then > > disable it and verify the feature detection fails. WDYT? > > Is this not doing it when it runs via the stable test? Ah, I forgot this entire directly is enabled for virtual/stable (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...). The more common pattern I think is to explicitly toggle the RuntimeEnabledFeature state, but this is fine too. Maybe add a comment here (and in the other test) just mentioning that this tests expects to be run with and without the feature enabled via virtual/stable.
23 supportsCapture = false;	23 supportsPassive = false;

24 document.removeEventListener('test_event', query_function, query_options);	24 document.removeEventListener('test_event', query_function, query_options);

25 assert_equals(supportsCapture, internals.runtimeFlags.eventListenerOptionsEn abled);	25 assert_equals(supportsPassive, internals.runtimeFlags.eventListenerOptionsEn abled);

26 t.done();	26 t.done();

27 }, "Supports Capture");	27 }, "Supports Passive");

28 </script>	28 </script>

OLD	NEW