Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1563613002: Add GL error usage metrics for glTexImage* APIs (Closed)

Created:
4 years, 11 months ago by Justin Novosad
Modified:
4 years, 11 months ago
Reviewers:
rkaplow, piman
CC:
chromium-reviews, piman+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GL error usage metrics for glTexImage* APIs This change adds histograms that track errors that occur in calls that allocate GPU textures. The motivation is to track the impact of tweaking GPU resource management parameters. In particular, there is a desire to increase the limit of the skia texture cache in order to solve some performance issues. This histogram will allow us to measure the impact of that change on GPU resource allocation failure rates. BUG=464835 Committed: https://crrev.com/0cad1f4cc187083f997c91f117529ba3ff5b191a Cr-Commit-Position: refs/heads/master@{#368165}

Patch Set 1 #

Patch Set 2 : fix gn build #

Total comments: 1

Patch Set 3 : local -> uma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M gpu/command_buffer/service/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 2 chunks +10 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gl_utils.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Justin Novosad
PTAL. piman: I added you as co-owner of this histogram because I thought you might ...
4 years, 11 months ago (2016-01-05 21:57:55 UTC) #2
piman
lgtm
4 years, 11 months ago (2016-01-05 22:41:10 UTC) #3
rkaplow
https://codereview.chromium.org/1563613002/diff/20001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/1563613002/diff/20001/gpu/command_buffer/service/texture_manager.cc#newcode2267 gpu/command_buffer/service/texture_manager.cc:2267: LOCAL_HISTOGRAM_CUSTOM_ENUMERATION("GPU.Error.TexImage3D", error, i think you mean UMA here - ...
4 years, 11 months ago (2016-01-06 18:40:00 UTC) #4
rkaplow
lgtm
4 years, 11 months ago (2016-01-07 18:24:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563613002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563613002/30001
4 years, 11 months ago (2016-01-07 20:17:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 11 months ago (2016-01-07 21:49:00 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 21:49:48 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0cad1f4cc187083f997c91f117529ba3ff5b191a
Cr-Commit-Position: refs/heads/master@{#368165}

Powered by Google App Engine
This is Rietveld 408576698