Implement networkingPrivate.setWifiTDLSEnabledState

chrome/common/extensions/api/networking_private.json

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [
   {
     "namespace":"networkingPrivate",
     "description": "none",
     "compiler_options": {
       "implemented_in": "chrome/browser/extensions/api/networking_private/networking_private_api.h"
@@ skipping 335 matching lines @@
             "type": "function",
             "parameters": [
               {
                 "name": "encryptedData",
                 "type": "string"
               }
             ],
             "description": "A callback function that receives base64-encoded encrypted data to send to a trusted device."
           }
         ]
+      },
+      {
+        "name": "setWifiTDLSEnabledState",
+        "description": "Enables TDLS for wifi traffic if available.",
+        "parameters": [
+          {
+            "name": "ip_or_mac_address",
+            "type": "string",
+            "description": "The IP or MAC address for which to enable TDLS."

[asargent_no_longer_on_chrome, 2014/02/10 18:23:26]

I am relatively unfamiliar with TDLS, but from my cursory reading it sounds liek
a way to establish device-to-device direct connections between 2 devices without
having to send traffic through a wireless router/access point. Assuming that's
correct, does the |ip_or_mac_address| being referred to here represent a peer
we're willing to connect to (eg TDLS can be enabled/disabled on an individual
basis for each peer)? Or does it represent the ip/mac address of one of our own
adapters, and serves as a master control for whether TDLS will be used to
connect to any peer for this adapter?

Please update the comment here to be specific about this.

[stevenjb, 2014/02/12 23:22:52]

Done.

+          },
+          {
+            "name": "enabled",
+            "type": "boolean",
+            "description": "If true, enable TDLS."

[tbarzic, 2014/02/07 23:17:41]

this suggests that enabled==false case is no-op, but the existence of
kTDLSTearDownOperation suggests the opposite :)

[stevenjb, 2014/02/12 23:22:52]

Done.

+          },
+          {
+            "name": "callback",
+            "type": "function",
+            "parameters": [
+              {
+                "name": "state",
+                "type": "string"
+              }
+            ],
+            "description": "A callback function that receives a string with the current TDLS state."

[asargent_no_longer_on_chrome, 2014/02/10 18:23:26]

What are the expected values of |state|? If this is just used to report the
success of the function call, then you can omit it and just communicate
success/failure with a callback that has no parameters with failure indicated
via a non-null runtime.lastError (which is auto-populated from the boolean you
pass to SendResponse in your NetworkingPrivateSetWifiTDLSEnabledStateFunction
functions, and in error cases sets runtime.lastError.message to the string you
set error_ to). 

If the result of the function is more complicated than just success failure and
you do need the string return value, then you should include in the comment each
of the possible values it can take and a brief explanation of the meaning of
each (if it isn't obvious from the value). 

[stevenjb, 2014/02/12 23:22:52]

Listed possible values; meaning should be clear within the context of someone
using the function.

Note: It has been requested that this be split up into SetEnabled / GetState, so
I will do that in a follow up and list the states in GetState.

+          }
+        ]
       }
     ],
     "events": [
       {
         "name": "onNetworksChanged",
         "type": "function",
         "description": "Fired when the properties change on any of the networks.  Sends a list of identifiers for networks whose properties have changed.",
         "parameters": [
           {
             "name": "changes",
@@ skipping 10 matching lines @@
           {
             "name": "changes",
             "type": "array",
             "items": { "type": "string" }
           }
         ]
       }
     ]
   }
 ]