Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1563493004: Disable non-crash dumps since we have a large enough list now. (Closed)

Created:
4 years, 11 months ago by DaleCurtis
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable non-crash dumps since we have a large enough list now. The top 15 bad drivers are (sent to Microsoft): RTKVHD64.sys : 2249 HdAudio.sys : 1246 CHDRT64.sys : 1210 stwrt64.sys : 1004 RTKVHDA.sys : 470 viahduaa.sys : 198 isstrtc.sys : 194 stwrt.sys : 163 USBAUDIO.sys : 119 IntcDAud.sys : 61 RtkHDAud.sys : 36 CHDRT32.sys : 30 BthA2DP.sys : 28 ADIHdAud.sys : 25 CHDART.sys : 21 Query (internal only, sorry): https://paste.googleplex.com/5147294596857856 UMA stats show 99.96% of audio threads never hang, 0.03% hang and 0.01% eventually recover. BUG=422522 TEST=none Committed: https://crrev.com/acbbd642c516a6203546749589aab2ce498169e9 Cr-Commit-Position: refs/heads/master@{#367709}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bug link. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M media/audio/audio_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
DaleCurtis
4 years, 11 months ago (2016-01-05 21:56:57 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-05 22:07:34 UTC) #3
xhwang
lgtm https://codereview.chromium.org/1563493004/diff/1/media/audio/audio_manager.h File media/audio/audio_manager.h (right): https://codereview.chromium.org/1563493004/diff/1/media/audio/audio_manager.h#newcode67 media/audio/audio_manager.h:67: // the future if Microsoft is able to ...
4 years, 11 months ago (2016-01-05 22:10:31 UTC) #4
DaleCurtis
https://codereview.chromium.org/1563493004/diff/1/media/audio/audio_manager.h File media/audio/audio_manager.h (right): https://codereview.chromium.org/1563493004/diff/1/media/audio/audio_manager.h#newcode67 media/audio/audio_manager.h:67: // the future if Microsoft is able to triage ...
4 years, 11 months ago (2016-01-05 23:03:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563493004/20001
4 years, 11 months ago (2016-01-05 23:05:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 00:12:24 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 00:13:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acbbd642c516a6203546749589aab2ce498169e9
Cr-Commit-Position: refs/heads/master@{#367709}

Powered by Google App Engine
This is Rietveld 408576698