Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1563473002: Refactor monotonic clock interface and use raw tick values in stopwatch (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor monotonic clock interface and use raw tick values in stopwatch - Split interface to provide direct access to raw clock value and clock frequency. - Update Stopwatch to use raw clock value and clock frequency instead of microseconds. - Fix possible initialization race on OSX R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/dd4ef2909893c055f584e1e8aeecd4c093b077e2

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -42 lines) Patch
M runtime/bin/utils_macos.cc View 1 2 chunks +5 lines, -11 lines 0 comments Download
M runtime/lib/stopwatch.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M runtime/vm/os_macos.cc View 4 chunks +29 lines, -15 lines 0 comments Download
M runtime/vm/os_win.cc View 2 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
4 years, 11 months ago (2016-01-05 17:51:36 UTC) #3
rmacnak
lgtm w/c https://codereview.chromium.org/1563473002/diff/1/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://codereview.chromium.org/1563473002/diff/1/runtime/vm/os_macos.cc#newcode112 runtime/vm/os_macos.cc:112: ASSERT(timebase_info.denom != 0); Also change the copy ...
4 years, 11 months ago (2016-01-05 18:28:52 UTC) #5
Cutch
https://codereview.chromium.org/1563473002/diff/1/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://codereview.chromium.org/1563473002/diff/1/runtime/vm/os_macos.cc#newcode112 runtime/vm/os_macos.cc:112: ASSERT(timebase_info.denom != 0); On 2016/01/05 18:28:52, rmacnak wrote: > ...
4 years, 11 months ago (2016-01-05 19:16:14 UTC) #6
Cutch
4 years, 11 months ago (2016-01-05 19:22:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dd4ef2909893c055f584e1e8aeecd4c093b077e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698