Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1563413002: Move fetchers into mojo/shell/fetcher (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move fetchers into mojo/shell/fetcher TBR=sky@chromium.org http://crbug.com/575308 Committed: https://crrev.com/81be0c208c2b82f2f674bbfb4c985ddf1057b76d Cr-Commit-Position: refs/heads/master@{#368234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -1889 lines) Patch
D mojo/fetcher/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/fetcher/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/fetcher/about_fetcher.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/fetcher/about_fetcher.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D mojo/fetcher/about_fetcher_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/fetcher/data_fetcher.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/fetcher/data_fetcher.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/fetcher/data_fetcher_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/fetcher/local_fetcher.h View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/fetcher/local_fetcher.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D mojo/fetcher/network_fetcher.h View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/fetcher/network_fetcher.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D mojo/fetcher/network_fetcher_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/fetcher/switches.h View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/fetcher/switches.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/fetcher/update_fetcher.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/fetcher/update_fetcher.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/fetcher/url_resolver.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/fetcher/url_resolver.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/fetcher/url_resolver_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 chunk +12 lines, -14 lines 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/fetcher/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
A + mojo/shell/fetcher/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/fetcher/about_fetcher.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/fetcher/about_fetcher.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/fetcher/about_fetcher_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
A + mojo/shell/fetcher/data_fetcher.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + mojo/shell/fetcher/data_fetcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/fetcher/data_fetcher_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
A + mojo/shell/fetcher/local_fetcher.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/fetcher/local_fetcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/fetcher/network_fetcher.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/fetcher/network_fetcher.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + mojo/shell/fetcher/network_fetcher_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
A + mojo/shell/fetcher/switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/shell/fetcher/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/fetcher/url_resolver.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/fetcher/url_resolver.cc View 5 chunks +5 lines, -5 lines 0 comments Download
A + mojo/shell/fetcher/url_resolver_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/package_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/package_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/package_manager/package_manager_impl.cc View 5 chunks +14 lines, -16 lines 0 comments Download

Dependent Patchsets:

Issue 1565343003 Patch 1
Issue 1565343003 Patch 20001

Messages

Total messages: 6 (2 generated)
Ben Goodger (Google)
4 years, 11 months ago (2016-01-08 00:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563413002/1
4 years, 11 months ago (2016-01-08 00:13:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 01:35:36 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 01:36:56 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/81be0c208c2b82f2f674bbfb4c985ddf1057b76d
Cr-Commit-Position: refs/heads/master@{#368234}

Powered by Google App Engine
This is Rietveld 408576698