Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1563383002: Fix a few missed references to boundTypeParameters. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a few missed references to boundTypeParameters. In 924f2f97b75bc9774fe49813806e574d1ddbccb1, this was renamed to `typeFormals`. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/daf4b9b49b39008f3d4408913b7808ecc15a3f5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-07 23:22:38 UTC) #2
Jennifer Messerly
LGTM, thank you!
4 years, 11 months ago (2016-01-07 23:26:37 UTC) #3
Jennifer Messerly
(btw, I also have this in https://codereview.chromium.org/1561233003/, which will hopefully land soon. I need to ...
4 years, 11 months ago (2016-01-07 23:33:25 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-07 23:40:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daf4b9b49b39008f3d4408913b7808ecc15a3f5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698