Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1563353002: Remove use of --no-preserve=mode argument to 'cp' (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Remove use of --no-preserve=mode argument to 'cp' This is not supported on OSX and is currently breaking the mac build. Committed: https://chromium.googlesource.com/webports/+/75ab043eeece68bc7d8de05ba9afdd7a68ae6880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ports/gtest/build.sh View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sam Clegg
4 years, 11 months ago (2016-01-07 19:56:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563353002/1
4 years, 11 months ago (2016-01-07 19:56:39 UTC) #4
binji
lgtm
4 years, 11 months ago (2016-01-07 20:26:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563353002/1
4 years, 11 months ago (2016-01-07 20:33:46 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 00:35:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/webports/+/75ab043eeece68bc7d8de05ba9afdd7a...

Powered by Google App Engine
This is Rietveld 408576698