Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 156333002: Enable icu_use_data_file_flag on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tab removed. log removed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | chrome/chrome_android_paks.gypi » ('j') | content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 43f73de1845bbf7255a8ae320a09b397e14bb083..b0addfa6b35b90903ec837f2ca1f6108428ccd28 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1304,8 +1304,9 @@
# can use breakpad for these builds.
'release_unwind_tables%': 0,
}],
- # TODO(jungshik): Turn this on on Android and Chrome OS
- ['OS!="android" and chromeos==0', {
+ # TODO(jshin): Turn this on on CrOS
+ # Should we also disable this when use_system_icu==1 on Linux?
+ ['chromeos==0 and android_webview_build==0', {
'icu_use_data_file_flag%': 1,
}],
],
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | chrome/chrome_android_paks.gypi » ('j') | content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698