build/android/pylib/gtest/setup.py - Issue 156333002: Enable icu_use_data_file_flag on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/setup.py

Issue 156333002: Enable icu_use_data_file_flag on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: icudtl.dat made readable Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/setup.py

diff --git a/build/android/pylib/gtest/setup.py b/build/android/pylib/gtest/setup.py

index 5d3c2c78a7c59bafe257382a373c32dabca66dc8..2e369a608a73197e3e98c3eb440018ec7ad3af23 100644

--- a/build/android/pylib/gtest/setup.py

+++ b/build/android/pylib/gtest/setup.py

@@ -124,7 +124,7 @@ def _GenerateDepsDirUsingIsolate(suite_name):

'--config-variable', 'OS', 'android',

'--config-variable', 'chromeos', '0',

'--config-variable', 'component', 'static_library',

- '--config-variable', 'icu_use_data_file_flag', '0',

+ '--config-variable', 'icu_use_data_file_flag', '1',

'--config-variable', 'use_openssl', '0',

]

assert not cmd_helper.RunCmd(isolate_cmd)