content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java - Issue 156333002: Enable icu_use_data_file_flag on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

Issue 156333002: Enable icu_use_data_file_flag on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java ('k') | content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

diff --git a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

index 252198a498cfdee03477e00f8b9fcf807ba8c0ce..89e73621f41d4551193aa1a8f6ed7e1f05ff589e 100644

--- a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

+++ b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

@@ -14,7 +14,16 @@ import org.chromium.content.browser.ResourceExtractor;

public class ChromiumLinkerTestApplication extends Application {

- private static final String[] MANDATORY_PAK_FILES = new String[] {"content_shell.pak"};

+ /**

+ * icudtl.dat provides ICU (i18n library) with all the data for its

+ * operation. We use to link it statically to our binary, but not any more

+ * so that we have to install it along with other mandatory pak files.

+ * See src/third_party/icu/README.chromium.

+ */

+ private static final String[] MANDATORY_PAK_FILES = new String[] {

+ "content_shell.pak",

+ "icudtl.dat"

+ };

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chromium_linker_test";

@Override