Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: build/common.gypi

Issue 156333002: Enable icu_use_data_file_flag on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0f2aaf301eca6e437d9fb14f72f607d6bf504a6b..b4722f73eb93631c0570b9866e4b5b5e68a1f187 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -823,6 +823,15 @@
'remoting%': 0,
'enable_printing%': 0,
}],
+
+ # By default, use ICU data file (icudtl.dat) on all platforms
+ # except when building Android WebView.
+ # TODO(jshin): Handle 'use_system_icu' on Linux (Chromium).
+ ['android_webview_build==0', {
+ 'icu_use_data_file_flag%' : 1,
+ }, {
+ 'icu_use_data_file_flag%' : 0,
+ }],
],
# Set this to 1 to enable use of concatenated impulse responses
@@ -972,6 +981,7 @@
'use_libjpeg_turbo%': '<(use_libjpeg_turbo)',
'use_system_libjpeg%': '<(use_system_libjpeg)',
'android_webview_build%': '<(android_webview_build)',
+ 'icu_use_data_file_flag%': '<(icu_use_data_file_flag)',
'gyp_managed_install%': 0,
'create_standalone_apk%': 1,
'enable_app_list%': '<(enable_app_list)',
@@ -1273,9 +1283,6 @@
# IPC fuzzer is disabled by default.
'enable_ipc_fuzzer%': 0,
- # Whether or not to use "icu*.dat" file for ICU data.
- # Do not use it by default.
- 'icu_use_data_file_flag%': 0,
# Force disable libstdc++ debug mode.
'disable_glibcxx_debug%': 0,
@@ -1317,7 +1324,6 @@
}],
['OS=="win"', {
'windows_driver_kit_path%': '$(WDK_DIR)',
- 'icu_use_data_file_flag%': 1,
}],
['os_posix==1 and OS!="mac" and OS!="ios"', {
'conditions': [
@@ -1343,17 +1349,8 @@
# can use breakpad for these builds.
'release_unwind_tables%': 0,
}],
- # TODO(jungshik): Turn this on on Android.
- # For ChromeOS, this should be turned on in chromeos-chrome.ebuild
- # file as well by adding icu_use_data_file_flag=1 to BUILD_DEFINES.
- ['OS!="android"', {
- 'icu_use_data_file_flag%': 1,
- }],
],
}], # os_posix==1 and OS!="mac" and OS!="ios"
- ['OS=="mac"', {
- 'icu_use_data_file_flag%': 1,
- }], # os=="mac"
['OS=="ios"', {
'disable_nacl%': 1,
'enable_background%': 0,

Powered by Google App Engine
This is Rietveld 408576698