content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java - Issue 156333002: Enable icu_use_data_file_flag on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

Issue 156333002: Enable icu_use_data_file_flag on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Log.w -> Log.e in ResourceExtractor-deleteFiles Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java ('K') | « content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

index 43ded486615d63a25794450936ca5fc8310c0bf0..a881b6a9000a7ebceb6651b337391bdcbb4e0b4b 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

@@ -14,7 +14,10 @@ import org.chromium.content.browser.ResourceExtractor;

public class ContentShellApplication extends ContentApplication {

- private static final String[] MANDATORY_PAK_FILES = new String[] {"content_shell.pak"};

+ private static final String[] MANDATORY_PAK_FILES = new String[] {

+ "content_shell.pak",

+ "icudtl.dat"

Andrew Hayden (chromium.org) 2014/02/25 13:52:56 Same here, should link to docs.

+ };

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "content_shell";

@Override