win: Better setting of DI for register capture test

win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:86, chromium:571144
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/417097b91fe872404db257532d5126cfd7bfb438

[scottmg, 2016-01-09 03:50:03]

Description was changed from

==========
win: Better setting of DI for register capture test

R=mark@chromium.org
BUG=crashpad:87, chromium:571144
==========

to

==========
win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:87, chromium:571144
==========

[scottmg, 2016-01-09 03:51:11]

Description was changed from

==========
win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:87, chromium:571144
==========

to

==========
win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:86, chromium:571144
==========

[Mark Mentovai, 2016-01-10 04:46:29]

LGTM

https://codereview.chromium.org/1563273004/diff/1/handler/win/crashy_test_pro...
File handler/win/crashy_test_program.cc (right):

https://codereview.chromium.org/1563273004/diff/1/handler/win/crashy_test_pro...
handler/win/crashy_test_program.cc:97: // Creates a background thread, suspends
it, and sets EDI/RDI to point at
Creates a suspended background thread. Otherwise this sounds racy.

[scottmg, 2016-01-10 21:32:08]

https://codereview.chromium.org/1563273004/diff/1/handler/win/crashy_test_pro...
File handler/win/crashy_test_program.cc (right):

https://codereview.chromium.org/1563273004/diff/1/handler/win/crashy_test_pro...
handler/win/crashy_test_program.cc:97: // Creates a background thread, suspends
it, and sets EDI/RDI to point at
On 2016/01/10 04:46:29, Mark Mentovai wrote:
> Creates a suspended background thread. Otherwise this sounds racy.

Done.

[scottmg, 2016-01-10 21:32:25]

Description was changed from

==========
win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:86, chromium:571144
==========

to

==========
win: Better setting of DI for register capture test

The previous approach was nice for its simplicity, but unfortunately
didn't work when the compiler decided to do some of its confounded
"optimization".

R=mark@chromium.org
BUG=crashpad:86, chromium:571144

Committed:
https://chromium.googlesource.com/crashpad/crashpad/+/417097b91fe872404db2575...
==========

[scottmg, 2016-01-10 21:32:26]

Committed patchset #2 (id:20001) manually as
417097b91fe872404db257532d5126cfd7bfb438 (presubmit successful).