Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1563223002: Add Future.any and Stream.fromFutures. (Closed)

Created:
4 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -0 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/async/future.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M sdk/lib/async/stream.dart View 1 1 chunk +41 lines, -0 lines 0 comments Download
M tests/lib/async/future_test.dart View 2 chunks +73 lines, -0 lines 0 comments Download
A tests/lib/async/stream_from_futures_test.dart View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
Simple support functions. Saw a use for Future.any today, and Stream.fromFutures is related functionality: Using ...
4 years, 11 months ago (2016-01-07 10:31:55 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1563223002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/1563223002/diff/1/sdk/lib/async/stream.dart#newcode131 sdk/lib/async/stream.dart:131: controller = new StreamController<T>(sync: true); Merge these two ...
4 years, 11 months ago (2016-01-07 13:57:13 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 8487d57e48d05615ab64bbbab62e3d1260aed2cb (presubmit successful).
4 years, 11 months ago (2016-01-08 09:18:25 UTC) #5
Lasse Reichstein Nielsen
4 years, 11 months ago (2016-01-08 09:18:48 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1563223002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/1563223002/diff/1/sdk/lib/async/stream.dart#n...
sdk/lib/async/stream.dart:131: controller = new StreamController<T>(sync: true);
On 2016/01/07 13:57:13, floitsch wrote:
> Merge these two lines?

Done.

Powered by Google App Engine
This is Rietveld 408576698