Added capability on Windows to get the physical dimensions of your attached monitors. Also added th…

content/browser/gpu/gpu_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_internals_ui.h"
 
 #include <stddef.h>
 
+#include <sstream>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/i18n/time_formatting.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 16 matching lines @@
 #include "gpu/config/gpu_feature_type.h"
 #include "gpu/config/gpu_info.h"
 #include "third_party/angle/src/common/version.h"
 #include "ui/gl/gpu_switching_manager.h"
 
 #if defined(OS_LINUX) && defined(USE_X11)
 #include <X11/Xlib.h>
 #endif
 #if defined(OS_WIN)
 #include "ui/base/win/shell.h"
+#include "ui/gfx/win/physical_size.h"
 #endif
 
 #if defined(OS_LINUX) && defined(USE_X11)
 #include "ui/base/x/x11_util.h"
 #include "ui/gfx/x/x11_atom_cache.h"
 #endif
 
 namespace content {
 namespace {
 
@@ skipping 86 matching lines @@
   }
 #if defined(OS_WIN)
   std::string compositor =
       ui::win::IsAeroGlassEnabled() ? "Aero Glass" : "none";
   basic_info->Append(
       NewDescriptionValuePair("Desktop compositing", compositor));
   if (GpuDataManagerImpl::GetInstance()->ShouldUseWarp()) {
     basic_info->Append(NewDescriptionValuePair("Using WARP",
         new base::FundamentalValue(true)));
   }
+
+  std::vector<gfx::DisplaySize> display_sizes;
+  gfx::GetPhysicalSizeForDisplays(&display_sizes);
+  for (size_t i = 0; i < display_sizes.size(); ++i) {

[robliao, 2016/01/11 18:42:20]

Could probably use the C++11 foreach here too.
for (const auto& display_size : display_sizes)

[Bret, 2016/01/12 00:23:46]

Done.

+    const gfx::DisplaySize& display_size = display_sizes[i];
+    int w = display_size.width_mm;
+    int h = display_size.height_mm;
+    double size_mm = sqrt(w * w + h * h);
+    double size_inches = 0.0393701 * size_mm;
+    double rounded_size_inches = floor(10.0 * size_inches) / 10.0;
+    std::ostringstream size_stream;

[scottmg, 2016/01/09 01:00:05]

I see we've recently changed the style guide to allow streams (!!), but other
parts of this file and most of Chrome use base::StringPrintf, so I think it'd be
better to stick to that here.

[Bret, 2016/01/12 00:23:46]

Done.

+    size_stream << rounded_size_inches << "\"";
+    std::ostringstream description_stream;
+    description_stream << "Diagonal Monitor Size of "
+                       << display_size.display_name;
+    basic_info->Append(
+        NewDescriptionValuePair(description_stream.str(), size_stream.str()));
+  }
 #endif
 
   std::string disabled_extensions;
   GpuDataManagerImpl::GetInstance()->GetDisabledExtensions(
       &disabled_extensions);
 
   basic_info->Append(
       NewDescriptionValuePair("Driver vendor", gpu_info.driver_vendor));
   basic_info->Append(NewDescriptionValuePair("Driver version",
                                              gpu_info.driver_version));
@@ skipping 362 matching lines @@
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new GpuMessageHandler());
 
   // Set up the chrome://gpu/ source.
   BrowserContext* browser_context =
       web_ui->GetWebContents()->GetBrowserContext();
   WebUIDataSource::Add(browser_context, CreateGpuHTMLSource());
 }
 
 }  // namespace content