Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1563073002: Re-enable io2014 + add cds2014 tests for devenv. (Closed)

Created:
4 years, 11 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
Pete Williamson, binji
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Re-enable io2014 + add cds2014 tests for devenv. Re-enable io2014 devenv tests, add cds2014 tests. Only enable for glibc/x86_64 for now. Deferring devenv-latest to a separate CL. BUG=None TEST=demo2014_test R=binji@chromium.org,petewil@chromium.org Committed: https://chromium.googlesource.com/webports/+/cbbd346b5890ad134492663c9ae0189ac2ad6dc2

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : fix #

Patch Set 6 : try #

Patch Set 7 : fix #

Patch Set 8 : fix #

Total comments: 2

Patch Set 9 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -180 lines) Patch
M ports/devenv-latest/build.sh View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -5 lines 0 comments Download
M ports/devenv/build.sh View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ports/devenv/demo2014_test.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ports/devenv/devenv_large_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
D ports/devenv/io2014_test.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
M ports/devenv/tests/common.js View 1 2 3 4 5 6 7 5 chunks +14 lines, -11 lines 0 comments Download
A + ports/devenv/tests/demo2014_test.html View 1 chunk +1 line, -1 line 0 comments Download
A ports/devenv/tests/demo2014_test.js View 1 2 3 4 5 6 7 1 chunk +138 lines, -0 lines 0 comments Download
M ports/devenv/tests/devenv_small_test.js View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
D ports/devenv/tests/io2014_test.html View 1 chunk +0 lines, -18 lines 0 comments Download
D ports/devenv/tests/io2014_test.js View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bradnelson
4 years, 9 months ago (2016-03-11 05:32:47 UTC) #5
binji
lgtm % trybot failures Looks like there's no pnacl git: "git: command not found"? https://codereview.chromium.org/1563073002/diff/140001/ports/devenv/tests/demo2014_test.js ...
4 years, 9 months ago (2016-03-11 19:30:39 UTC) #6
bradnelson
So I have some guesses on the failures with latest, but want to land the ...
4 years, 9 months ago (2016-03-11 23:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563073002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563073002/160001
4 years, 9 months ago (2016-03-11 23:26:18 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 01:23:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/webports/+/cbbd346b5890ad134492663c9ae0189a...

Powered by Google App Engine
This is Rietveld 408576698