Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1563043002: Make minidump-2-core.cc build with -Wformat. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/google_breakpad/common/breakpad_types.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
4 years, 11 months ago (2016-01-06 22:16:53 UTC) #3
Nico
lgtm, nice change!
4 years, 11 months ago (2016-01-06 22:17:14 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-06 22:17:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
863883f93ff555f480d98ec9ffff168ddddcc24a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698