Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 156303004: With --site-per-process, avoid a crash when a subframe process goes away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index faafe5fb49ca385998d05dc7ed188b21e19d26fd..db90529d248664b8ab0cb041402a1c3a6369117a 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -72,13 +72,13 @@ void FrameTreeNode::RemoveChild(FrameTreeNode* child) {
}
}
-void FrameTreeNode::ResetForMainFrameSwap() {
+void FrameTreeNode::ResetForNewProcess() {
frame_id_ = kInvalidFrameId;
current_url_ = GURL();
// The children may not have been cleared if a cross-process navigation
// commits before the old process cleans everything up. Make sure the child
- // nodes get deleted.
+ // nodes get deleted before swapping to a new process.
children_.clear();
}
« no previous file with comments | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698