content/browser/renderer_host/render_view_host_impl.cc - Issue 156303004: With --site-per-process, avoid a crash when a subframe process goes away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 156303004: With --site-per-process, avoid a crash when a subframe process goes away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Disable on GTK, add test. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_tree.cc ('K') | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/browser/site_per_process_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 872152c996ab612ec0381ba171301b53faeef40c..a79df2a45ac243906ff6bc133e18f5ba3fe1aeb3 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1435,7 +1435,7 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {

// TODO(creis): Once subframes can be in different processes, we'll need to

nasko 2014/02/11 04:49:16 nit: This comment is now stale, right?

Charlie Reis 2014/02/12 00:27:57 Ah, of course. Done.

// clear just the FrameTreeNodes affected by the crash (and their subtrees).

main_frame_id_ = -1;

- delegate_->GetFrameTree()->ResetForMainFrameSwap();

+ delegate_->GetFrameTree()->RenderProcessGone(this);

// Our base class RenderWidgetHost needs to reset some stuff.

RendererExited(render_view_termination_status_, exit_code);