Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: runtime/observatory/tests/service/get_source_report_test.dart

Issue 1562993003: Add the forceCompile param to _getSourceReport. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_source_report_test.dart
diff --git a/runtime/observatory/tests/service/get_source_report_test.dart b/runtime/observatory/tests/service/get_source_report_test.dart
index e0e511ea19f4498b462e03fda942ce8fbd55fa5f..71345eeaeea99fd934b8ccf3742db6d054bc716d 100644
--- a/runtime/observatory/tests/service/get_source_report_test.dart
+++ b/runtime/observatory/tests/service/get_source_report_test.dart
@@ -34,6 +34,15 @@ void testFunction() {
MyClass.myFunction(10000);
}
+bool allRangesCompiled(coverage) {
+ for (int i = 0; i < coverage['ranges'].length; i++) {
+ if (!coverage['ranges'][i]['compiled']) {
+ return false;
+ }
+ }
+ return true;
+}
+
var tests = [
hasStoppedAtBreakpoint,
@@ -64,11 +73,21 @@ hasStoppedAtBreakpoint,
'scriptId' : func.location.script.id };
var coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
- expect(coverage['ranges'].length, 5);
+ expect(coverage['ranges'].length, 6);
expect(coverage['ranges'][0], equals(expectedRange));
expect(coverage['scripts'].length, 1);
expect(coverage['scripts'][0]['uri'],
endsWith('get_source_report_test.dart'));
+ expect(allRangesCompiled(coverage), isFalse);
+
+ // Force compilation.
+ params = { 'reports' : ['Coverage'],
+ 'scriptId' : func.location.script.id,
+ 'forceCompile' : true };
+ coverage = await isolate.invokeRpcNoUpgrade('_getSourceReport', params);
+ expect(coverage['type'], equals('SourceReport'));
+ expect(coverage['ranges'].length, 6);
+ expect(allRangesCompiled(coverage), isTrue);
// One function
params = { 'reports' : ['Coverage'],
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698