Add the forceCompile param to _getSourceReport.

Add the forceCompile param to _getSourceReport.

Deal with some empty ranges that were being emitted.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/a283265955d6c11e542008a3a94f6b35feb72491

[turnidge, 2016-01-06 21:38:42]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-01-06 21:43:46]

LGTM with some suggestions

https://codereview.chromium.org/1562993003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/get_source_report_test.dart (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_source_report_test.dart:74: if
(!coverage['ranges'][i]['compiled']) {
This could be a helper function

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:2354: if (js->HasParam("forceCompile") &&
if (BoolParameter::Parse(js->LookupParam("forceCompile"), false)) {
  ...
}

[rmacnak, 2016-01-07 18:08:43]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-01-07 18:08:43]

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/source_repor...
File runtime/vm/source_report.cc (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:250: if (func.IsAsyncFunction()) {
Similar story with sync* and async* functions.

IsAsyncFunction() || IsAsyncGeneratory() || IsSyncGenerator()

[turnidge, 2016-01-07 19:25:17]

https://codereview.chromium.org/1562993003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/get_source_report_test.dart (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/get_source_report_test.dart:74: if
(!coverage['ranges'][i]['compiled']) {
On 2016/01/06 21:43:45, Cutch wrote:
> This could be a helper function

Done.

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:2354: if (js->HasParam("forceCompile") &&
On 2016/01/06 21:43:45, Cutch wrote:
> if (BoolParameter::Parse(js->LookupParam("forceCompile"), false)) {
>   ...
> }

Done.

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/source_repor...
File runtime/vm/source_report.cc (right):

https://codereview.chromium.org/1562993003/diff/20001/runtime/vm/source_repor...
runtime/vm/source_report.cc:250: if (func.IsAsyncFunction()) {
On 2016/01/07 18:08:43, rmacnak wrote:
> Similar story with sync* and async* functions.
> 
> IsAsyncFunction() || IsAsyncGeneratory() || IsSyncGenerator()

Done.

[turnidge, 2016-01-07 19:33:33]

Description was changed from

==========
Add the forceCompile param to _getSourceReport.

Deal with some empty ranges that were being emitted.

BUG=
==========

to

==========
Add the forceCompile param to _getSourceReport.

Deal with some empty ranges that were being emitted.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a283265955d6c11e542008a3a94f6b35feb72491
==========

[turnidge, 2016-01-07 19:33:34]

Committed patchset #3 (id:40001) manually as
a283265955d6c11e542008a3a94f6b35feb72491 (presubmit successful).

[0941114136a, 2016-01-07 19:35:34]

0941114136a@gmail.com changed reviewers:
+ 0941114136a@gmail.com

[0941114136a, 2016-01-07 19:51:22]

asd

[0941114136a, 2016-01-07 19:51:40]

asdsa