Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1562943002: SkTime: Stop using POSIX entensions to time.h for timezone (Closed)

Created:
4 years, 11 months ago by hal.canary
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTime: Stop using POSIX entensions to time.h for timezone SkTime::GetDateTime() isn't used anywhere in production, so change it to return current UTC time, rather than local time. Also, move code into SkTime out of ports. A later CL will remove empty files. BUG=skia:4736 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1562943002 [mtklein] Only deleting unused API. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/2b12376849c10df26cb6ecade2475460282f6a3f

Patch Set 1 #

Patch Set 2 : 2016-01-06 (Wednesday) 15:48:07 EST #

Total comments: 2

Patch Set 3 : 2016-01-11 (Monday) 17:28:49 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -115 lines) Patch
M include/core/SkTime.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/animator/SkTime.cpp View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
M src/core/SkTime.cpp View 2 chunks +41 lines, -0 lines 0 comments Download
M src/ports/SkTime_Unix.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M src/ports/SkTime_win.cpp View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
hal.canary
PTAL
4 years, 11 months ago (2016-01-06 20:42:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562943002/1
4 years, 11 months ago (2016-01-06 20:42:54 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/5174)
4 years, 11 months ago (2016-01-06 20:45:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562943002/20001
4 years, 11 months ago (2016-01-06 20:49:10 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 21:08:02 UTC) #12
mtklein
https://codereview.chromium.org/1562943002/diff/20001/src/animator/SkTime.cpp File src/animator/SkTime.cpp (right): https://codereview.chromium.org/1562943002/diff/20001/src/animator/SkTime.cpp#newcode13 src/animator/SkTime.cpp:13: SkMSec gForceTickCount = (SkMSec) -1; Don't see any use ...
4 years, 11 months ago (2016-01-06 21:22:26 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562943002/40001
4 years, 11 months ago (2016-01-11 22:29:19 UTC) #15
hal.canary
reed@, PTAL @API (gForceTickCount is not used since https://crrev.com/1422513003 ) https://codereview.chromium.org/1562943002/diff/20001/src/animator/SkTime.cpp File src/animator/SkTime.cpp (right): https://codereview.chromium.org/1562943002/diff/20001/src/animator/SkTime.cpp#newcode13 ...
4 years, 11 months ago (2016-01-11 22:31:41 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 22:40:55 UTC) #19
mtklein
lgtm
4 years, 11 months ago (2016-01-12 19:53:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562943002/40001
4 years, 11 months ago (2016-01-12 19:53:34 UTC) #23
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 19:55:31 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2b12376849c10df26cb6ecade2475460282f6a3f

Powered by Google App Engine
This is Rietveld 408576698