Issue 1562893002: dart2js cps: Generate increment and compound operators.

Issue 1562893002: dart2js cps: Generate increment and compound operators. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang), Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Generate increment and compound operators. Expressions like `i = i + E` now become `i += E` or `++i` if E=1. The same applies for field and index access. BUG= R=sigmund@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/d2a6980c1c0b2dc5556c6c0c8240d5676937d22f

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -27 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/builtin_operator.dart	View	1 2 3	1 chunk	+21 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 2 3	4 chunks	+66 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View	1 2 3	2 chunks	+39 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_codeUnitAt_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_gvn_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

Siggi Cherem (dart-lang)

lgtm Other than manually inspecting the output of some tests, do we have any unit-test ...

4 years, 11 months ago (2016-01-06 20:57:14 UTC) #3

sra1

StringConcatenate with exactly two arguments is an important case for StringBuffer code (search for "_contents" ...

4 years, 11 months ago (2016-01-06 21:19:04 UTC) #4

asgerf

We have tests that check the exact output. I just forgot to update them (and ...

4 years, 11 months ago (2016-01-06 21:51:31 UTC) #5

asgerf

4 years, 11 months ago (2016-01-07 00:56:37 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
d2a6980c1c0b2dc5556c6c0c8240d5676937d22f (presubmit successful).