Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1562883003: [wasm] Add tests that pass float/double parameters directly for binops and unops. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add tests that pass float/double parameters directly for binops and unops. R=rossberg@chromium.org BUG= Committed: https://crrev.com/5341e9fa39bb9b5f59165f18631775bd7ce5e340 Cr-Commit-Position: refs/heads/master@{#33152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -30 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +75 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 11 months ago (2016-01-07 10:05:14 UTC) #1
rossberg
lgtm
4 years, 11 months ago (2016-01-07 10:48:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562883003/1
4 years, 11 months ago (2016-01-07 10:54:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 10:55:30 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 10:56:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5341e9fa39bb9b5f59165f18631775bd7ce5e340
Cr-Commit-Position: refs/heads/master@{#33152}

Powered by Google App Engine
This is Rietveld 408576698