Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1562833002: Revert of Enable url_formatter::ElideUrl and url_formatter::ElideHost for aura Android (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable url_formatter::ElideUrl and url_formatter::ElideHost for aura Android (patchset #10 id:240001 of https://codereview.chromium.org/1428593004/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Enable url_formatter::ElideUrl and url_formatter::ElideHost for aura Android > > Aura Android uses text_utils_gfx.cc and GetStringWidthF is > implemented in the file. So it is safe to use > url_formatter::ElideUrl and url_formatter::ElideHost for > aura Android. > > BUG=507792 > > Committed: https://crrev.com/cd2dd0a028b2f2efe3f1053eb34091e30e0d1548 > Cr-Commit-Position: refs/heads/master@{#358442} TBR=mfomitchev@chromium.org,palmer@chromium.org,msw@chromium.org,pkasting@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507792 Committed: https://crrev.com/6fec5636f1555c9fb267a8f8944815e3fdd5625a Cr-Commit-Position: refs/heads/master@{#367833}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M components/url_formatter/BUILD.gn View 3 chunks +4 lines, -5 lines 0 comments Download
M components/url_formatter/elide_url.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/url_formatter/elide_url.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/url_formatter/url_formatter.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/text_elider.cc View 3 chunks +16 lines, -17 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
bshe
Created Revert of Enable url_formatter::ElideUrl and url_formatter::ElideHost for aura Android
4 years, 11 months ago (2016-01-06 16:24:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562833002/1
4 years, 11 months ago (2016-01-06 16:24:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 16:25:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6fec5636f1555c9fb267a8f8944815e3fdd5625a Cr-Commit-Position: refs/heads/master@{#367833}
4 years, 11 months ago (2016-01-06 16:26:05 UTC) #5
msw
https://codereview.chromium.org/1562833002/diff/1/ui/gfx/text_elider.cc File ui/gfx/text_elider.cc (left): https://codereview.chromium.org/1562833002/diff/1/ui/gfx/text_elider.cc#oldcode245 ui/gfx/text_elider.cc:245: // TODO(bshe): 5000 is out dated. We should remove ...
4 years, 11 months ago (2016-01-06 18:58:11 UTC) #6
bshe
4 years, 11 months ago (2016-01-06 19:05:30 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1562833002/diff/1/ui/gfx/text_elider.cc
File ui/gfx/text_elider.cc (left):

https://codereview.chromium.org/1562833002/diff/1/ui/gfx/text_elider.cc#oldco...
ui/gfx/text_elider.cc:245: // TODO(bshe): 5000 is out dated. We should remove
it. See crbug.com/551660.
On 2016/01/06 18:58:11, msw wrote:
> It would have been nice to keep this updated comment.

Will upload a new patch to add the comment back.

Powered by Google App Engine
This is Rietveld 408576698