Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156283004: Fix d8 dependency in chromium_builder_asan target. (Closed)

Created:
6 years, 10 months ago by Martin Barbella
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix d8 dependency in chromium_builder_asan target. BUG= R=inferno@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Martin Barbella
Could you take a look at this when you get a chance, mstarzinger? Inferno mentioned ...
6 years, 10 months ago (2014-02-11 16:38:24 UTC) #1
aarya
rubber-stamp lgtm so that build could be unbroken.
6 years, 10 months ago (2014-02-11 17:08:14 UTC) #2
Martin Barbella
The CQ bit was checked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-11 17:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mbarbella@chromium.org/156283004/1
6 years, 10 months ago (2014-02-11 17:09:19 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 18:51:30 UTC) #5
Message was sent while issue was closed. 
Change committed as 250457

Powered by Google App Engine
This is Rietveld 408576698