Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1562803004: [Chromedriver] Enabling java tests ClickScrollingTest & WindowSwitchingTest on android waterfall bo… (Closed)

Created:
4 years, 11 months ago by gmanikpure
Modified:
4 years, 10 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Enabling java tests ClickScrollingTest & WindowSwitchingTest on android waterfall bots. BUG=chromedriver:1006, chromedriver:1044 Committed: https://crrev.com/835b8cdd89f21d32915d5f0ec46478808a98385c Cr-Commit-Position: refs/heads/master@{#374716}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits #

Total comments: 2

Patch Set 3 : WindowSwitchingTest now works fine on latest version of stable & beta #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/test/chromedriver/test/test_expectations View 1 2 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gmanikpure
Hi Sam, Could you please have a look? For chromedriver issue 1006, ClickScollingTest works fine ...
4 years, 11 months ago (2016-01-06 22:51:47 UTC) #2
samuong
https://codereview.chromium.org/1562803004/diff/1/chrome/test/chromedriver/test/test_expectations File chrome/test/chromedriver/test/test_expectations (right): https://codereview.chromium.org/1562803004/diff/1/chrome/test/chromedriver/test/test_expectations#newcode237 chrome/test/chromedriver/test/test_expectations:237: # https://bugs.chromium.org/p/chromedriver/issues/detail?id=1006 'ClickScrollingTest.testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrameThatIsOutOfView', is this supposed to be two ...
4 years, 11 months ago (2016-01-12 22:41:55 UTC) #3
gmanikpure
Hi Sam, Re-tested on the latest versions of chrome_stable,chrome_beta,chromium & chromedriver_webview_shell and enabled/disabled the tests ...
4 years, 10 months ago (2016-02-08 22:37:21 UTC) #4
samuong
lgtm
4 years, 10 months ago (2016-02-10 19:59:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562803004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562803004/40001
4 years, 10 months ago (2016-02-10 20:07:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 20:52:49 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/835b8cdd89f21d32915d5f0ec46478808a98385c
Cr-Commit-Position: refs/heads/master@{#374716}

Powered by Google App Engine
This is Rietveld 408576698