Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1562793002: Use std::move() in PruneCrashReportThread (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Use std::move() in PruneCrashReportThread Crashpad uses std::move() as of 6bebb1082933. scoped_ptr<>::Pass() will be unavailable once mini_chromium is updated to or past e128dcf10122. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c46a676624cf5a7ce3af392c1f90560046bb9e93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M handler/prune_crash_reports_thread.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 15:10:31 UTC) #2
Robert Sesek
lgtm
4 years, 11 months ago (2016-01-06 16:34:35 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:15:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c46a676624cf5a7ce3af392c1f90560046bb9e93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698