Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: ui/base/ime/ime_engine_handler_interface.h

Issue 1562733002: Make InputMethodEngine to inherit from new added class InputMethodEngineBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/ime_engine_handler_interface.h
diff --git a/ui/base/ime/ime_engine_handler_interface.h b/ui/base/ime/ime_engine_handler_interface.h
index 27e265a05dabf385777fb16ce1980ffd2e7305c1..6290841b3bd529f8df41d1c6c3ba52412d88553f 100644
--- a/ui/base/ime/ime_engine_handler_interface.h
+++ b/ui/base/ime/ime_engine_handler_interface.h
@@ -95,9 +95,6 @@ class UI_BASE_IME_EXPORT IMEEngineHandlerInterface {
// Called when the IME is disabled.
virtual void Disable() = 0;
- // Called when a property is activated or changed.
- virtual void PropertyActivate(const std::string& property_name) = 0;
-
// Called when the IME is reset.
virtual void Reset() = 0;
@@ -233,6 +230,9 @@ class UI_BASE_IME_EXPORT IMEEngineHandlerInterface {
bool is_auxiliary_text_visible;
};
+ // Called when a property is activated or changed.
+ virtual void PropertyActivate(const std::string& property_name) = 0;
+
// Called when the candidate in lookup table is clicked. The |index| is 0
// based candidate index in lookup table.
virtual void CandidateClicked(uint32_t index) = 0;
@@ -270,7 +270,7 @@ class UI_BASE_IME_EXPORT IMEEngineHandlerInterface {
// Hides the input view window (from API call).
virtual void HideInputView() = 0;
-#endif
+#endif // defined(OS_CHROMEOS)
protected:
IMEEngineHandlerInterface() {}

Powered by Google App Engine
This is Rietveld 408576698