chrome/chrome_browser.gypi - Issue 1562733002: Make InputMethodEngine to inherit from new added class InputMethodEngineBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1562733002: Make InputMethodEngine to inherit from new added class InputMethodEngineBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add OWNERS file Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/input_method/input_method_engine_base.cc ('K') | « chrome/browser/input_method/input_method_engine_base.cc ('k') | ui/base/ime/ime_engine_handler_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 28d3d882f65e2fb585e3ad18c0ca389e70e9cee7..3caafda6430eeb0076c63bc23d6cee5016ebfdd8 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -979,6 +979,8 @@

'browser/download/notification/download_notification.h',

'browser/download/notification/download_notification_manager.cc',

'browser/download/notification/download_notification_manager.h',

+ 'browser/input_method/input_method_engine_base.cc',

+ 'browser/input_method/input_method_engine_base.h',

'browser/media/protected_media_identifier_permission_context.cc',

'browser/media/protected_media_identifier_permission_context.h',

'browser/media/protected_media_identifier_permission_context_factory.cc',

@@ -3596,9 +3598,13 @@

'<(SHARED_INTERMEDIATE_DIR)/ui/chromeos/resources/grit/ui_chromeos_resources_map.cc',

'dependencies': [

+ '../base/base.gyp:base',

'browser_chromeos',

'../components/components.gyp:user_manager',

'../ui/chromeos/ui_chromeos.gyp:ui_chromeos_resources',

+ '../ui/base/ime/ui_base_ime.gyp:ui_base_ime',

+ '../ui/base/ui_base.gyp:ui_base',

+ '../ui/events/events.gyp:dom_keycode_converter',

}],

['use_cups==1', {