Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 1562703002: move docs generation (Closed)

Created:
4 years, 11 months ago by rkotlerimgtec
Modified:
4 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move Doxyfile files to docs and associated makefile. This is a prelude to allowing a docs directory for all the RST files as well as expanding the makefile to build the docs for those too, not just the doxygen output. The doxygen html has been moved to build/docs/html so it's not in a source directory. Gitignore has been fixed to allow files in docs now without complaining. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4cba1cbba5cb2b0a487734a822ff39607a32926d

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase with latest and remove docs/html from clean-all because it's in the build directory now #

Total comments: 4

Patch Set 3 : changes suggested by stichnot #

Patch Set 4 : changes suggested by stichnot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2346 lines) Patch
M .gitignore View 1 3 1 chunk +0 lines, -1 line 0 comments Download
D Doxyfile View 1 chunk +0 lines, -2334 lines 0 comments Download
M Makefile.standalone View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
A + docs/Doxyfile View 2 chunks +8 lines, -8 lines 0 comments Download
A docs/Makefile.standalone View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
rkotlerimgtec
4 years, 11 months ago (2016-01-06 04:23:32 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/1562703002/diff/1/.gitignore File .gitignore (left): https://codereview.chromium.org/1562703002/diff/1/.gitignore#oldcode13 .gitignore:13: /docs/ Should this be preserved as /docs/html/ ? Also, ...
4 years, 11 months ago (2016-01-06 19:59:32 UTC) #4
rkotlerimgtec
https://codereview.chromium.org/1562703002/diff/1/.gitignore File .gitignore (left): https://codereview.chromium.org/1562703002/diff/1/.gitignore#oldcode13 .gitignore:13: /docs/ On 2016/01/06 19:59:32, stichnot wrote: > Should this ...
4 years, 11 months ago (2016-01-07 00:02:53 UTC) #5
Jim Stichnoth
Can you rebase and upload a new version? There are (expected) conflicts after landing the ...
4 years, 11 months ago (2016-01-07 01:27:29 UTC) #6
rkotlerimgtec
4 years, 11 months ago (2016-01-07 01:52:16 UTC) #8
rkotlerimgtec
On 2016/01/07 01:52:16, rkotlerimgtec wrote: 408 -i x8632,nonsfi,sse2,O2 -e x8632,nonsfi,test_select \ 408 -i x8632,nonsfi,sse2,O2 \ ...
4 years, 11 months ago (2016-01-07 01:56:39 UTC) #9
Jim Stichnoth
https://codereview.chromium.org/1562703002/diff/40001/.gitignore File .gitignore (left): https://codereview.chromium.org/1562703002/diff/40001/.gitignore#oldcode13 .gitignore:13: /docs/html/ I don't think this should be deleted. https://codereview.chromium.org/1562703002/diff/40001/Makefile.standalone ...
4 years, 11 months ago (2016-01-07 02:00:39 UTC) #10
rkotlerimgtec
https://codereview.chromium.org/1562703002/diff/40001/.gitignore File .gitignore (left): https://codereview.chromium.org/1562703002/diff/40001/.gitignore#oldcode13 .gitignore:13: /docs/html/ On 2016/01/07 02:00:39, stichnot wrote: > I don't ...
4 years, 11 months ago (2016-01-07 04:47:53 UTC) #11
Jim Stichnoth
Sorry, somehow I completely missed that doxygen output was moved into the build/ directory. This ...
4 years, 11 months ago (2016-01-07 16:22:10 UTC) #12
rkotlerimgtec
4 years, 11 months ago (2016-01-07 16:38:18 UTC) #13
Jim Stichnoth
LGTM. BTW, if you "make clean-all" and then "make docs", you get an error because ...
4 years, 11 months ago (2016-01-07 16:44:58 UTC) #14
Jim Stichnoth
4 years, 11 months ago (2016-01-07 16:45:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:80001) manually as
4cba1cbba5cb2b0a487734a822ff39607a32926d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698