Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1562693002: gyp: Disable media recording unittests on ChromeCast (Closed)

Created:
4 years, 11 months ago by zhengxiong
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gyp: Disable media recording unittests on ChromeCast BUG=internal b/26039735 Committed: https://crrev.com/210774c7e18ecc3ba10e02e25b852940f1e95d66 Cr-Commit-Position: refs/heads/master@{#367866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
zhengxiong
4 years, 11 months ago (2016-01-06 03:09:42 UTC) #3
Avi (use Gerrit)
lgtm ok
4 years, 11 months ago (2016-01-06 16:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562693002/1
4 years, 11 months ago (2016-01-06 17:35:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 18:33:50 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/210774c7e18ecc3ba10e02e25b852940f1e95d66 Cr-Commit-Position: refs/heads/master@{#367866}
4 years, 11 months ago (2016-01-06 18:34:59 UTC) #10
mbjorge1
Isn't there a BUILD.gn file that should get similar changes? chromium/src/content/test/BUILD.gn:content_untittests I think?
4 years, 11 months ago (2016-01-06 19:02:35 UTC) #12
zhengxiong
4 years, 11 months ago (2016-01-06 19:11:39 UTC) #13
Message was sent while issue was closed.
On 2016/01/06 19:02:35, mbjorge1 wrote:
> Isn't there a BUILD.gn file that should get similar changes?
> chromium/src/content/test/BUILD.gn:content_untittests I think?

We already patched gn in https://codereview.chromium.org/1506333003

Powered by Google App Engine
This is Rietveld 408576698