Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1562623002:
Prepare for updating Noto fonts on CrOS (Closed)
|
Created:
4 years, 11 months ago by jungshik at Google Modified:
4 years, 11 months ago CC:
chromium-reviews, jshin+watch_chromium.org, wuyingbing1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrepare for updating Noto fonts on CrOS
Use Noto Color Emoji instead of Noto Sans Emoji.
In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji.
https://chromium-review.googlesource.com/320493 will be landed after this.
BUG=574585
Committed: https://crrev.com/97690d8625f0e8d4ac372806bc253c3d7c83393b
Cr-Commit-Position: refs/heads/master@{#371848}
Patch Set 1 #Patch Set 2 : drop inputtools' change #
Messages
Total messages: 29 (8 generated)
Description was changed from ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. This also partially fixes bug 574585. BUG=574585 ========== to ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. This also partially fixes bug 574585. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ==========
jshin@chromium.org changed reviewers: + shuchen@chromium.org, thakis@chromium.org
shuchen: please reivew input-tools thakis: PTAL - apps/*. Thanks
rs-lgtm
shuchen@chromium.org changed reviewers: + rsadam@chromium.org
The common.css file is copied from sources under google3 by a script. rsadam@ should know how to do it. I will change the files google3 soon.
On 2016/01/06 01:37:23, Shu Chen wrote: > The common.css file is copied from sources under google3 by a script. > > rsadam@ should know how to do it. > > I will change the files google3 soon. README.chromium said that Chrome's copy comes from this repo and there's an instruction for getting Chrome's copy updated to the upstream in README.chromium. https://github.com/googlei18n/google-input-tools.git So, I'm a bit confused as to the canonical upstream. Whichever is canonical, I can wait a little while (a day or two) if it can be updated soon. BTW, there's also a section in README.chromium where local modifications are recorded. I added an entry about my change there. rsadam@ : your advice on how to deal with this change would be appreciated.
Hi jsin@, apologies for the late reply, I was out on vacation. The changes need to be made in the following order: 1) Update ime code in google3 2) Release a new open source version to github input_method 3) Pull the open source version from github into chromium third_party. On 2016/01/06 18:25:09, jshin (out until Jan 3) wrote: > On 2016/01/06 01:37:23, Shu Chen wrote: > > The common.css file is copied from sources under google3 by a script. > > > > rsadam@ should know how to do it. > > > > I will change the files google3 soon. > > README.chromium said that Chrome's copy comes from this repo and there's an > instruction for getting Chrome's copy updated to the upstream in > README.chromium. > > https://github.com/googlei18n/google-input-tools.git > > So, I'm a bit confused as to the canonical upstream. Whichever is canonical, I > can wait a little while (a day or two) if it can be updated soon. > > BTW, there's also a section in README.chromium where local modifications are > recorded. I added an entry about my change there. > > rsadam@ : your advice on how to deal with this change would be appreciated.
CC'ed wuyingbing@. rsadam@, can you please help us do the update? Or let us know the doc/script for the update? Thanks. The change in google3 has been made by https://critique.corp.google.com/#review/111476858.
On 2016/01/08 01:11:18, Shu Chen wrote: > CC'ed wuyingbing@. > > rsadam@, can you please help us do the update? Or let us know the doc/script for > the update? Thanks. > > The change in google3 has been made by > https://critique.corp.google.com/#review/111476858. On it: Waiting for LGTM to increment manifest number on cl/111690262
Oops, didn't mean green the cl. nlgtm
* lngtm
On 2016/01/08 14:40:36, rsadam wrote: > * lngtm * not lgtm ? Can't remember what the command it.
On 2016/01/08 14:38:51, rsadam wrote: > On 2016/01/08 01:11:18, Shu Chen wrote: > > CC'ed wuyingbing@. > > > > rsadam@, can you please help us do the update? Or let us know the doc/script > for > > the update? Thanks. > > > > The change in google3 has been made by > > https://critique.corp.google.com/#review/111476858. > > On it: Waiting for L-G-T-M to increment manifest number on cl/111690262 FYI. I've lgtm'ed the changes in google3 and github.
On 2016/01/08 15:33:21, Shu Chen wrote: > On 2016/01/08 14:38:51, rsadam wrote: > > On 2016/01/08 01:11:18, Shu Chen wrote: > > > CC'ed wuyingbing@. > > > > > > rsadam@, can you please help us do the update? Or let us know the doc/script > > for > > > the update? Thanks. > > > > > > The change in google3 has been made by > > > https://critique.corp.google.com/#review/111476858. > > > > On it: Waiting for L-G-T-M to increment manifest number on cl/111690262 > > FYI. I've lgtm'ed the changes in google3 and github. not lgtm :/
On 2016/01/08 15:33:52, Shu Chen wrote: > On 2016/01/08 15:33:21, Shu Chen wrote: > > On 2016/01/08 14:38:51, rsadam wrote: > > > On 2016/01/08 01:11:18, Shu Chen wrote: > > > > CC'ed wuyingbing@. > > > > > > > > rsadam@, can you please help us do the update? Or let us know the > doc/script > > > for > > > > the update? Thanks. > > > > > > > > The change in google3 has been made by > > > > https://critique.corp.google.com/#review/111476858. > > > > > > On it: Waiting for L-G-T-M to increment manifest number on cl/111690262 > > > > FYI. I've lgtm'ed the changes in google3 and github. > > not lgtm :/ Thanks! Working on the pull from github -> third_party/google_input_tools. I haven't sync'd chromium in 3 months, and so running into some weird errors there, will update when I've verified that the fallback keyboard is still functional.
On 2016/01/08 15:52:27, rsadam wrote: > On 2016/01/08 15:33:52, Shu Chen wrote: > > On 2016/01/08 15:33:21, Shu Chen wrote: > > > On 2016/01/08 14:38:51, rsadam wrote: > > > > On 2016/01/08 01:11:18, Shu Chen wrote: > > > > > CC'ed wuyingbing@. > > > > > > > > > > rsadam@, can you please help us do the update? Or let us know the > > doc/script > > > > for > > > > > the update? Thanks. > > > > > > > > > > The change in google3 has been made by > > > > > https://critique.corp.google.com/#review/111476858. > > > > > > > > On it: Waiting for L-G-T-M to increment manifest number on cl/111690262 > > > > > > FYI. I've lgtm'ed the changes in google3 and github. > > > > not lgtm :/ > > Thanks! Working on the pull from github -> third_party/google_input_tools. I > haven't sync'd chromium in 3 months, and so running into some weird errors > there, will update when I've verified that the fallback keyboard is still > functional. CL up on chromium: https://codereview.chromium.org/1576613002/.
Description was changed from ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. This also partially fixes bug 574585. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ========== to ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ==========
Dropped a change for input tools. The rest of the CL is just changing the default value of font preferences (already approved).
On 2016/01/25 19:16:24, jshin (jungshik at google) wrote: > Dropped a change for input tools. The rest of the CL is just changing the > default value of font preferences (already approved). lgtm
lgtm
The CQ bit was checked by jshin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1562623002/#ps20001 (title: "drop inputtools' change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562623002/20001
Message was sent while issue was closed.
Description was changed from ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ========== to ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 ========== to ========== Prepare for updating Noto fonts on CrOS Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 Committed: https://crrev.com/97690d8625f0e8d4ac372806bc253c3d7c83393b Cr-Commit-Position: refs/heads/master@{#371848} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/97690d8625f0e8d4ac372806bc253c3d7c83393b Cr-Commit-Position: refs/heads/master@{#371848} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
