chromeos/network/network_state_handler_observer.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_state_handler_observer.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: IsShuttingDown -> OnShuttingDown Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_state_handler_observer.h

diff --git a/chromeos/network/network_state_handler_observer.h b/chromeos/network/network_state_handler_observer.h

index a25dc59c5fcafef2da3557a1f2fb74e5a6964e58..b1a7ae6fbac4fd199aba1b267dea2af726f1a55f 100644

--- a/chromeos/network/network_state_handler_observer.h

+++ b/chromeos/network/network_state_handler_observer.h

@@ -53,7 +53,7 @@ class CHROMEOS_EXPORT NetworkStateHandlerObserver {

// Called just before NetworkStateHandler is destroyed so that observers

// can safely stop observing.

- virtual void IsShuttingDown();

+ virtual void OnShuttingDown();

private:

DISALLOW_COPY_AND_ASSIGN(NetworkStateHandlerObserver);