chromeos/network/network_configuration_handler.h - Issue 1562593002: Fix potential crashes in NetworkHandler code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_configuration_handler.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test

Patch Set: IsShuttingDown -> OnShuttingDown Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_configuration_handler.h

diff --git a/chromeos/network/network_configuration_handler.h b/chromeos/network/network_configuration_handler.h

index 6b0bbbdf34f0cdaa23d12fe35f76826531b565de..d76be197fafd9e549f57c06e6b35f9b814dc575d 100644

--- a/chromeos/network/network_configuration_handler.h

+++ b/chromeos/network/network_configuration_handler.h

@@ -205,7 +205,7 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler

// Map of in-progress deleter instances. Owned by this class.

std::map<std::string, ProfileEntryDeleter*> profile_entry_deleters_;

- base::ObserverList<NetworkConfigurationObserver> observers_;

+ base::ObserverList<NetworkConfigurationObserver, true> observers_;

DISALLOW_COPY_AND_ASSIGN(NetworkConfigurationHandler);

};