Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chromeos/network/host_resolver_impl_chromeos.cc

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test
Patch Set: IsShuttingDown -> OnShuttingDown Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/host_resolver_impl_chromeos.cc
diff --git a/chromeos/network/host_resolver_impl_chromeos.cc b/chromeos/network/host_resolver_impl_chromeos.cc
index ce0cd1807f1e7ae79860d51148caffb5997e578d..61a9da905d364b514e1c6781e7980dfb4537ec74 100644
--- a/chromeos/network/host_resolver_impl_chromeos.cc
+++ b/chromeos/network/host_resolver_impl_chromeos.cc
@@ -26,7 +26,7 @@ namespace chromeos {
//
// An instance of this class is created on the NetworkHandler (UI) thread and
// manages its own lifetime, destroying itself when NetworkStateHandlerObserver
-// ::IsShuttingDown() gets called.
+// ::OnShuttingDown() gets called.
class HostResolverImplChromeOS::NetworkObserver
: public chromeos::NetworkStateHandlerObserver {
@@ -96,7 +96,7 @@ class HostResolverImplChromeOS::NetworkObserver
CallResolverSetIpAddress(ipv4_address, ipv6_address);
}
- void IsShuttingDown() override { delete this; }
+ void OnShuttingDown() override { delete this; }
void CallResolverSetIpAddress(const std::string& ipv4_address,
const std::string& ipv6_address) {
« no previous file with comments | « chromeos/network/client_cert_resolver.h ('k') | chromeos/network/managed_network_configuration_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698