Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test
Patch Set: IsShuttingDown -> OnShuttingDown Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl.cc ('k') | chromeos/network/auto_connect_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc b/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
index 01e9c51cf08415210a67c4974fcfacb415723574..b45809c6e0520e93af24cb3a13965b18340d4196 100644
--- a/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
+++ b/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
@@ -118,6 +118,17 @@ class VpnProviderApiTest : public ExtensionApiTest,
VpnProviderApiTest() {}
~VpnProviderApiTest() override {}
+ void SetUpOnMainThread() override {
+ ExtensionApiTest::SetUpOnMainThread();
+ NetworkHandler::Get()->network_configuration_handler()->AddObserver(this);
+ }
+
+ void TearDownOnMainThread() override {
+ ExtensionApiTest::TearDownOnMainThread();
+ NetworkHandler::Get()->network_configuration_handler()->RemoveObserver(
+ this);
+ }
+
void SetUpInProcessBrowserTestFixture() override {
ExtensionApiTest::SetUpInProcessBrowserTestFixture();
test_client_ = new TestShillThirdPartyVpnDriverClient();
@@ -135,7 +146,6 @@ class VpnProviderApiTest : public ExtensionApiTest,
}
void LoadVpnExtension() {
- NetworkHandler::Get()->network_configuration_handler()->AddObserver(this);
extension_ = LoadExtension(test_data_dir_.AppendASCII("vpn_provider"));
extension_id_ = extension_->id();
service_ = VpnServiceFactory::GetForBrowserContext(profile());
« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl.cc ('k') | chromeos/network/auto_connect_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698