Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: chromeos/network/managed_network_configuration_handler_impl.h

Issue 1562593002: Fix potential crashes in NetworkHandler code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test
Patch Set: IsShuttingDown -> OnShuttingDown Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_ 5 #ifndef CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_
6 #define CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_ 6 #define CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 // Owns the currently running PolicyApplicators. 208 // Owns the currently running PolicyApplicators.
209 UserToPolicyApplicatorMap policy_applicators_; 209 UserToPolicyApplicatorMap policy_applicators_;
210 210
211 // Per userhash (or empty string for device policy), contains the GUIDs of the 211 // Per userhash (or empty string for device policy), contains the GUIDs of the
212 // policies that were modified. 212 // policies that were modified.
213 // If this map contains a userhash as key, it means that a policy application 213 // If this map contains a userhash as key, it means that a policy application
214 // for this userhash is pending even if no policies were modified and the 214 // for this userhash is pending even if no policies were modified and the
215 // associated set of GUIDs is empty. 215 // associated set of GUIDs is empty.
216 UserToModifiedPoliciesMap queued_modified_policies_; 216 UserToModifiedPoliciesMap queued_modified_policies_;
217 217
218 base::ObserverList<NetworkPolicyObserver> observers_; 218 base::ObserverList<NetworkPolicyObserver, true> observers_;
219 219
220 // For Shill client callbacks 220 // For Shill client callbacks
221 base::WeakPtrFactory<ManagedNetworkConfigurationHandlerImpl> 221 base::WeakPtrFactory<ManagedNetworkConfigurationHandlerImpl>
222 weak_ptr_factory_; 222 weak_ptr_factory_;
223 223
224 DISALLOW_COPY_AND_ASSIGN(ManagedNetworkConfigurationHandlerImpl); 224 DISALLOW_COPY_AND_ASSIGN(ManagedNetworkConfigurationHandlerImpl);
225 }; 225 };
226 226
227 } // namespace chromeos 227 } // namespace chromeos
228 228
229 #endif // CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_ 229 #endif // CHROMEOS_NETWORK_MANAGED_NETWORK_CONFIGURATION_HANDLER_IMPL_H_
OLDNEW
« no previous file with comments | « chromeos/network/host_resolver_impl_chromeos.cc ('k') | chromeos/network/network_configuration_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698