Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1562543002: move .rst to docs (Closed)

Created:
4 years, 11 months ago by rkotlerimgtec
Modified:
4 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make sure clean-all is not too aggressive #

Total comments: 2

Patch Set 3 : changes suggested by stichnot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2049 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ALLOCATION.rst View 1 chunk +0 lines, -126 lines 0 comments Download
A DESIGN.rst View 1 chunk +0 lines, -1494 lines 0 comments Download
DESIGN.rst View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D LOWERING.rst View 1 chunk +0 lines, -239 lines 0 comments Download
M Makefile.standalone View 1 1 chunk +1 line, -1 line 0 comments Download
A README.rst View 1 chunk +0 lines, -192 lines 0 comments Download
README.rst View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + docs/ALLOCATION.rst View 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/DESIGN.rst View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/LOWERING.rst View 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/README.rst View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rkotlerimgtec
4 years, 11 months ago (2016-01-05 19:33:37 UTC) #3
rkotlerimgtec
4 years, 11 months ago (2016-01-05 20:34:08 UTC) #4
Jim Stichnoth
I think the interwebs may have some links floating around, pointing to the existing top-level ...
4 years, 11 months ago (2016-01-06 19:52:39 UTC) #5
rkotlerimgtec
soft links for README.rst and DESIGN.rst were added per your suggestion. https://codereview.chromium.org/1562543002/diff/20001/Makefile.standalone File Makefile.standalone (right): ...
4 years, 11 months ago (2016-01-06 22:28:30 UTC) #6
Jim Stichnoth
lgtm
4 years, 11 months ago (2016-01-07 01:22:07 UTC) #7
Jim Stichnoth
4 years, 11 months ago (2016-01-07 01:22:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4f69e0187faff889d211949e1b8d9a57acb7fa80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698