Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1562513002: Disable several tests, fix PPC build. (Closed)

Created:
4 years, 11 months ago by bradn
Modified:
4 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable several tests, fix PPC build. Work around ppc assembler use of Mul, Div macros. Disable several tests that fail for nosse4. Disable several tests that fail for msan. BUG= R=titzer@chromium.org Committed: https://crrev.com/0cf8254213605c0f850d8ffe91932398977fcb55 Cr-Commit-Position: refs/heads/master@{#33126}

Patch Set 1 #

Patch Set 2 : revise #

Patch Set 3 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 14 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
titzer
lgtm, though I am surprised that simple comparison tests are failing with nosse4.
4 years, 11 months ago (2016-01-05 18:46:32 UTC) #1
bradn
Root cause seems to be ceil/floor + other rounding ops.
4 years, 11 months ago (2016-01-05 18:54:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562513002/40001
4 years, 11 months ago (2016-01-05 18:55:35 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-05 19:15:56 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 19:16:43 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0cf8254213605c0f850d8ffe91932398977fcb55
Cr-Commit-Position: refs/heads/master@{#33126}

Powered by Google App Engine
This is Rietveld 408576698