Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1562493002: Cousins may not share style when ascendant affected bits set. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cousins may not share style when ascendant affected bits set. childrenOrSiblingsAffectedBy* are set during style matching. Cousins may not share style in such cases since those affected bits may be set on uncommon ancestors. Calling setUnique on ComputedStyle in such cases to avoid style sharing. This is also true for siblings in which case preceding siblings need to get the affected bits set when we have adjacent selectors. BUG=424104 Committed: https://crrev.com/1aa1bb688e772e6ab21b70c507cc51f76a5bdf1c Cr-Commit-Position: refs/heads/master@{#369029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/children-affected-by-style-sharing.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/children-affected-by-style-sharing-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562493002/1
4 years, 11 months ago (2016-01-05 17:45:32 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 18:56:08 UTC) #4
rune
4 years, 11 months ago (2016-01-05 19:39:49 UTC) #6
rune
ping
4 years, 11 months ago (2016-01-11 11:38:27 UTC) #7
esprehn
Hmm I think this seems right. We should really rethink all this style sharing stuff, ...
4 years, 11 months ago (2016-01-12 20:38:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562493002/1
4 years, 11 months ago (2016-01-12 20:44:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/100882)
4 years, 11 months ago (2016-01-12 22:26:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562493002/1
4 years, 11 months ago (2016-01-12 22:40:48 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 23:24:02 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 23:25:11 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aa1bb688e772e6ab21b70c507cc51f76a5bdf1c
Cr-Commit-Position: refs/heads/master@{#369029}

Powered by Google App Engine
This is Rietveld 408576698