Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1562473002: MIPS: Remove JIC/JIALC forbidden slot checks in simulator (Closed)

Created:
4 years, 11 months ago by miran.karic
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove JIC/JIALC forbidden slot checks in simulator JIC and JIALC instructions do not have a forbidden slot so their simulator implementation should not call CheckForbiddenSlot function. BUG= Committed: https://crrev.com/718a554dddd9670e72c414d6257fa51d0833d8e5 Cr-Commit-Position: refs/heads/master@{#33130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/mips/simulator-mips.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
balazs.kilvady
LGTM
4 years, 11 months ago (2016-01-05 19:01:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1562473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1562473002/1
4 years, 11 months ago (2016-01-05 22:09:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 22:30:07 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 22:31:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/718a554dddd9670e72c414d6257fa51d0833d8e5
Cr-Commit-Position: refs/heads/master@{#33130}

Powered by Google App Engine
This is Rietveld 408576698